[llvm-commits] LibCallAliasAnalysis should be in anonymous namespace
Török Edwin
edwintorok at gmail.com
Fri May 9 13:38:19 PDT 2008
Matthijs Kooijman wrote:
> Hi,
>
>
>> -namespace llvm {
>> +namespace {
>> /// LibCallAliasAnalysis - Alias analysis driven from LibCallInfo.
>> struct LibCallAliasAnalysis : public FunctionPass, AliasAnalysis {
>> static char ID; // Class identification
>>
> Following other examples, shouldn't there also be a VISIBILITY_HIDDEN put in
> there somewhere?
Probably yes, however I don't understand what implications
VISIBILITY_HIDDEN has,
so I have only commited the namespace change for now.
I would leave the VISIBILITY_HIDDEN stuff till after the release.
--Edwin
More information about the llvm-commits
mailing list