[llvm-commits] LibCallAliasAnalysis should be in anonymous namespace

[Chris Lattner]

On May 8, 2008, at 2:05 PM, Török Edwin wrote:

> Hi,
>
> I got a linker failure because of multiple definition of llvm::X in
> LibCallAliasAnalysis.
> The second definition was in a pass I am writing, and I haven't  
> noticed
> I have the same bug until now.
> I think the namespace should be anonymous, like for other analysis.

Sounds good to me, go for it.  Thanks!

-Chris

>
>
> Ok to commit?
>
> Index: lib/Analysis/LibCallAliasAnalysis.cpp
> ===================================================================
> --- lib/Analysis/LibCallAliasAnalysis.cpp       (revision 50866)
> +++ lib/Analysis/LibCallAliasAnalysis.cpp       (working copy)
> @@ -18,7 +18,7 @@
> #include "llvm/Target/TargetData.h"
> using namespace llvm;
>
> -namespace llvm {
> +namespace {
>   /// LibCallAliasAnalysis - Alias analysis driven from LibCallInfo.
>   struct LibCallAliasAnalysis : public FunctionPass, AliasAnalysis {
>     static char ID; // Class identification
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits