[llvm-commits] LibCallAliasAnalysis should be in anonymous namespace

[Török Edwin]

Hi,

I got a linker failure because of multiple definition of llvm::X in
LibCallAliasAnalysis.
The second definition was in a pass I am writing, and I haven't noticed
I have the same bug until now.
I think the namespace should be anonymous, like for other analysis.

Ok to commit?

Index: lib/Analysis/LibCallAliasAnalysis.cpp
===================================================================
--- lib/Analysis/LibCallAliasAnalysis.cpp       (revision 50866)
+++ lib/Analysis/LibCallAliasAnalysis.cpp       (working copy)
@@ -18,7 +18,7 @@
 #include "llvm/Target/TargetData.h"
 using namespace llvm;

-namespace llvm {
+namespace {
   /// LibCallAliasAnalysis - Alias analysis driven from LibCallInfo.
   struct LibCallAliasAnalysis : public FunctionPass, AliasAnalysis {
     static char ID; // Class identification