[llvm-commits] [test-suite] r50678 - in /test-suite/trunk: Makefile.programs TEST.nightly.Makefile TEST.nightly.report

[Chris Lattner]

On May 5, 2008, at 4:05 PM, Devang Patel wrote:

> Author: dpatel
> Date: Mon May  5 18:05:59 2008
> New Revision: 50678
>
> URL: http://llvm.org/viewvc/llvm-project?rev=50678&view=rev
> Log:
> Add OPT_BETA support.

more details:

> =
> =
> =
> =
> =
> =
> =
> =
> ======================================================================
> --- test-suite/trunk/TEST.nightly.report (original)
> +++ test-suite/trunk/TEST.nightly.report Mon May  5 18:05:59 2008
> @@ -56,6 +56,17 @@
>   return "-";
> }
>
> +sub OPTOPT_BETARatio {   # OPT/OPT-BETA
> +  my ($Cols, $Col) = @_;
> +  my $LLC = $Cols->[$Col-9];
> +  my $OPT_BETA = $Cols->[$Col-7];
> +  return "n/allc" if ($LLC eq "*");
> +  return "n/aopt" if ($OPT_BETA eq "*");
> +  return "n/a" if ($LLC eq "*" or $OPT_BETA eq "*");
> +  return sprintf("%3.2f", $LLC/$OPT_BETA) if ($LLC >= 0.1 and  
> $OPT_BETA >= 0.1);
> +  return "-";
> +}
> +
> # highlight the RATIO columns with green/red.
> $HilightColumns{14} = 1;
> $HilightColumns{15} = 1;
> @@ -74,16 +85,19 @@
>  ["Bytecode" , 'TEST-RESULT-compile: *([0-9]+)'],
>  ["LLC compile" , "TEST-RESULT-llc: .*$WallTimeRE"],
>  ["LLC-BETA compile" , "TEST-RESULT-llc-beta: .*$WallTimeRE"],
> + ["OPT-BETA compile" , "TEST-RESULT-opt-beta: .*$WallTimeRE"],
>  ["JIT codegen" , "TEST-RESULT-jit-comptime: .*$WallTimeRE"],
>  [],
>  ["GCC"      , 'TEST-RESULT-nat-time: program\s*([.0-9m:]+)',  
> \&FormatTime],
>  ["CBE"      , 'TEST-RESULT-cbe-time: program\s*([.0-9m:]+)',  
> \&FormatTime],
>  ["LLC"      , 'TEST-RESULT-llc-time: program\s*([.0-9m:]+)',  
> \&FormatTime],
>  ["LLC-BETA" , 'TEST-RESULT-llc-beta-time: program\s*([.0-9m:]+)', 
> \&FormatTime],
> + ["OPT-BETA" , 'TEST-RESULT-opt-beta-time: program\s*([.0-9m:]+)', 
> \&FormatTime],
>  ["JIT"      , 'TEST-RESULT-jit-time: program\s*([.0-9m:]+)',  
> \&FormatTime],
>  [],
>  ["GCC/CBE"  , \&GCCCBERatio],
>  ["GCC/LLC"  , \&GCCLLCRatio],
>  ["GCC/LLC-BETA"  , \&GCCLLC_BETARatio],
> - ["LLC/LLC-BETA"  , \&LLCLLC_BETARatio]
> + ["LLC/LLC-BETA"  , \&LLCLLC_BETARatio],
> + ["OPT/OPT-BETA"  , \&OPTOPT_BETARatio]
> );

This apparently broke all the ratios.  Note that things like  
GCCLLCRatio are column dependent.

> +$(PROGRAMS_TO_TEST:%=Output/%.llvm.optbeta.bc): \
> +Output/%.llvm.optbeta.bc: Output/%.linked.optbeta.bc $(LLVMLDPROG)
> +	-$(LLVMLD) $(STATS) $<  $(EXTRA_LINKTIME_OPT_FLAGS) $ 
> (LLVMLD_FLAGS) -lc $(LIBS) -o Output/$*.llvm.optbeta
> +
> +$(PROGRAMS_TO_TEST:%=Output/%.llvm.optbeta): \
> +Output/%.llvm.optbeta: Output/%.linked.optbeta.bc $(LLVMLDPROG)
> +	-$(LLVMLD) $(STATS) $<  $(LLVMLD_FLAGS) -lc $(LIBS) -o Output/ 
> $*.llvm.optbeta

This should be the same invocation as the previous rule, specifically  
you need to pass EXTRA_LINKTIME_OPT_FLAGS right?

> +$(PROGRAMS_TO_TEST:%=Output/%.bugpoint-opt-beta): \
> +Output/%.bugpoint-opt-beta: Output/%.llvm.optbeta.bc $(LBUGPOINT)  
> Output/%.out-nat
> +	$(LBUGPOINT) $< -run-llc $(BUGPOINT_OPTIONS) $(LLCBETAOPTION) $ 
> (BUGPOINT_ARGS)

This seems wrong, you're passing in optbeta.bc which is already  
optimized.

-Chris