[llvm-commits] [llvm] r50451 - /llvm/trunk/lib/CodeGen/DwarfWriter.cpp

[Chris Lattner]

On Apr 29, 2008, at 3:58 PM, Dale Johannesen wrote:
> Author: johannes
> Date: Tue Apr 29 17:58:20 2008
> New Revision: 50451
>
> URL: http://llvm.org/viewvc/llvm-project?rev=50451&view=rev
> Log:
> Make eh_frame objects by 8-byte aligned on 64-bit
> targets.

Hi Dale,

It's not obvious, but this is a correctness issue, please add a  
comment explaining what is going on here.  Thanks for fixing this!

-Chris

>
>
>
> Modified:
>    llvm/trunk/lib/CodeGen/DwarfWriter.cpp
>
> Modified: llvm/trunk/lib/CodeGen/DwarfWriter.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/DwarfWriter.cpp?rev=50451&r1=50450&r2=50451&view=diff
>
> = 
> = 
> = 
> = 
> = 
> = 
> = 
> = 
> ======================================================================
> --- llvm/trunk/lib/CodeGen/DwarfWriter.cpp (original)
> +++ llvm/trunk/lib/CodeGen/DwarfWriter.cpp Tue Apr 29 17:58:20 2008
> @@ -2876,7 +2876,8 @@
>     RI->getInitialFrameState(Moves);
>     EmitFrameMoves(NULL, 0, Moves, true);
>
> -    Asm->EmitAlignment(2, 0, 0, false);
> +    Asm->EmitAlignment(TD->getPointerSize() == sizeof(int32_t) ?  
> 2 : 3,
> +                       0, 0, false);
>     EmitLabel("eh_frame_common_end", Index);
>
>     Asm->EOL();
> @@ -2965,7 +2966,8 @@
>       // frame.
>       EmitFrameMoves("eh_func_begin", EHFrameInfo.Number,  
> EHFrameInfo.Moves, true);
>
> -      Asm->EmitAlignment(2, 0, 0, false);
> +      Asm->EmitAlignment(TD->getPointerSize() == sizeof(int32_t) ?  
> 2 : 3,
> +                         0, 0, false);
>       EmitLabel("eh_frame_end", EHFrameInfo.Number);
>
>       // If the function is marked used, this table should be also.   
> We cannot
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits