[llvm-commits] Speeding up instruction selection

[Evan Cheng]

Yes, moving it out of tblegen is a good idea. I don't have strong  
preference as to where it is moved to.

Evan

On Apr 23, 2008, at 3:31 PM, Dan Gohman wrote:

>
> On Apr 23, 2008, at 10:27 AM, Roman Levenstein wrote:
>>
>> Just to make it clear:
>> This patch is applied currently to the output of Tablegen.
>> But the proper patch will need to change the Tablegen to generate
>> correct *.inc files.
>> Thinking about it, I have a question:
>> Right now, the beginning of the generrated instruction selector files
>> is always the same, independent of the *.td file and target
>> architecture.
>> But it is generated by tablegen still and therefore cannot be
>> substituted easily, without changing the tablegen.
>> Question: May be it is better to define this common part in an  
>> include
>> file, e.g. ISelHeader.h, and then tablegen would generate only the
>> #include <llvm/CodeGen/ISelHeader.h> line. What do you think?
>
> Another option is to move common code into the
> SelectionDAGISel parent class, which is a common base class
> for each of the targets' DAGToDAGISel classes.
>
> Dan
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits