[llvm-commits] [llvm] r49795 - in /llvm/trunk: include/llvm/CodeGen/ScheduleDAG.h include/llvm/CodeGen/SelectionDAG.h include/llvm/CodeGen/SelectionDAGNodes.h lib/CodeGen/SelectionDAG/DAGCombiner.cpp lib/CodeGen/SelectionDAG/LegalizeDAG.cpp lib/CodeGen/SelectionDAG/LegalizeTypes.cpp lib/CodeGen/SelectionDAG/LegalizeTypes.h lib/CodeGen/SelectionDAG/ScheduleDAG.cpp lib/CodeGen/SelectionDAG/SelectionDAG.cpp lib/Target/X86/X86ISelLowering.cpp

[Dan Gohman]

On Apr 16, 2008, at 9:15 AM, Roman Levenstein wrote:
>
> -  SDOperand& operator= (SDOperandImpl& Op) {
> -      *(SDOperandImpl*)this = Op;
> +  SDUse& operator= (SDOperand& Op) {
> +      Operand = Op;
>       Next = NULL;
>       Prev = NULL;
>       return *this;
>   }
>
> -  SDOperand& operator= (const SDOperandImpl& Op) {
> -      *(SDOperandImpl*)this = Op;
> +  SDUse& operator= (const SDOperand& Op) {
> +      Operand = Op;
>       Next = NULL;
>       Prev = NULL;
>       return *this;
>   }

The first of these two assignment operators can be removed now; the
one taking a const reference will handle both cases.

>
>
> -  SDOperand& operator= (SDOperand& Op) {
> -      *(SDOperandImpl*)this = Op;
> +  SDUse& operator= (SDUse& Op) {
> +      Operand = Op;
>       Next = NULL;
>       Prev = NULL;
>       return *this;
>   }
>
> -  SDOperand& operator= (const SDOperand& Op) {
> -      *(SDOperandImpl*)this = Op;
> +  SDUse& operator= (const SDUse& Op) {
> +      Operand = Op;
>       Next = NULL;
>       Prev = NULL;
>       return *this;
>   }

Ditto.

Dan