[llvm-commits] [llvm-gcc-4.2] r49746 - /llvm-gcc-4.2/trunk/gcc/config/i386/llvm-i386.cpp

[Dale Johannesen]

On Apr 15, 2008, at 6:11 PM, Evan Cheng wrote:

> I am not sure that's the right approach. I think they are similar but
> not 100% the same and there is always the risk of fixing one and
> breaking the other.

There are definitely cases where they're not the same on x86-32.
I agree it's better to separate the functionality.

> Please check if it's gcc uses the same code path to determine return
> types. If so, please rename the function to something more  
> appropriate.
>
> Thanks,
>
> Evan
>
> On Apr 15, 2008, at 4:41 PM, Devang Patel wrote:
>
>>
>> On Apr 15, 2008, at 4:24 PM, Evan Cheng wrote:
>>
>>> But I am confused. This is
>>> llvm_x86_64_should_pass_aggregate_in_mixed_regs? It's used to
>>> determine argument passing, not return values. Are you fixing
>>> function
>>> return or argument passing?
>>
>> I'm trying to reuse it to determine return value registers.
>>
>> -
>> Devang
>>
>>
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits