[llvm-commits] [vmkit] r49523 - /vmkit/trunk/lib/JnJVM/VMCore/JavaJITInitialise.cpp

[Eric Christopher]

On Apr 11, 2008, at 12:52 AM, Owen Anderson wrote:
>
> On Apr 11, 2008, at 2:22 AM, Nicolas Geoffray wrote:
>>  LongAconsLLVM = Function::Create(type, GlobalValue::ExternalLinkage,
>> -                     "  
>> _ZN5jnjvm9ArrayLong5aconsEiPNS_10ClassArrayEPNS_5JnjvmE",
>> +                      
>> "_ZN5jnjvm9ArrayLong5aconsEiPNS_10ClassArrayEPNS_5JnjvmE",
>>                     module);
>>
>>  ObjectAconsLLVM = Function::Create(type,  
>> GlobalValue::ExternalLinkage,
>>
>
> For the record that's, um, kind of horrible.  Could you perhaps make  
> a wrapper function in extern "C" that calls into the Array one?   
> That way you wouldn't have to encode the C++ name mangling, and  
> perhaps make it more portable to Win32, or anything that doesn't use  
> Itanium ABI mangling.

FWIW I have an idea of a Function::Create that takes a mangler  
function as an option and will mangle the name as it creates the  
instruction.

Just haven't gotten to it yet.

-eric