[llvm-commits] [llvm] r49361 - in /llvm/trunk: include/llvm/Target/TargetOptions.h lib/CodeGen/DwarfWriter.cpp lib/Target/PowerPC/PPCRegisterInfo.cpp lib/Target/TargetMachine.cpp lib/Target/X86/X86RegisterInfo.cpp
dalej at apple.com
Tue Apr 8 10:50:01 PDT 2008
On Apr 8, 2008, at 10:42 AM, Duncan Sands wrote:
> On Tuesday 8 April 2008 17:11:07 Dale Johannesen wrote:
>> On Apr 8, 2008, at 12:16 AM, Duncan Sands wrote:
>>> Hi Dale, looks good to me except for the name.
>>>> + cl::opt<bool, true>
>>>> + DisableUnwindTables("disable-required-unwind-tables",
>>>> + cl::desc("Do not require unwinding info for all
>>>> + cl::location(UnwindTablesOptional),
>>>> + cl::init(false));
>>> How about "discard-unwind-tables" with comment
>>> "Only generate unwind tables for functions that require them".
>> "discard" implies discarding all of them which isn't necessarily what
> Correct, but the comment explains more clearly.
>> Is your objection to the length, or the meaning, or what?
> When I read disable-required-unwind-tables, I had no idea what it
> In fact I still don't see what it's supposed to mean.
> disable-require-unwind-tables makes more sense to me, but seems
> convoluted. How about unwind-tables-optional?
I'm OK with that.
More information about the llvm-commits