[llvm-commits] [llvm] r49361 - in /llvm/trunk: include/llvm/Target/TargetOptions.h lib/CodeGen/DwarfWriter.cpp lib/Target/PowerPC/PPCRegisterInfo.cpp lib/Target/TargetMachine.cpp lib/Target/X86/X86RegisterInfo.cpp

[Dale Johannesen]

On Apr 8, 2008, at 12:16 AM, Duncan Sands wrote:

> Hi Dale, looks good to me except for the name.
>
>> +  cl::opt<bool, true>
>> +  DisableUnwindTables("disable-required-unwind-tables",
>> +               cl::desc("Do not require unwinding info for all  
>> functions"),
>> +               cl::location(UnwindTablesOptional),
>> +               cl::init(false));
>
> How about "discard-unwind-tables" with comment
> "Only generate unwind tables for functions that require them".

"discard" implies discarding all of them which isn't necessarily what  
happens.  Is your objection to the length, or the meaning, or what?