[llvm-commits] [llvm-gcc-4.2] r49234 - /llvm-gcc-4.2/trunk/gcc/llvm-abi.h

Devang Patel dpatel at apple.com
Sat Apr 5 10:28:46 PDT 2008


On Apr 4, 2008, at 11:41 PM, Duncan Sands wrote:

> Hi Devang,
>
>> +// getLLVMAggregateTypeForStructReturn - Return LLVM type if TY  
>> can be
>
> TY -> Ty

All parameters are explicitly capitalized in comments at the beginning  
of function. This is GCC coding convention.

I'll fix all other typos. Thanks!
-
Devang
>
>
>> +// returnes as multiple values, otherwise return NULL. This is the  
>> default
>
> returnes -> returns
>
>> +// target indepdendent implementation.
>
> indepdendent -> independent
>
>> +// LLVM_SCALAR_TYPE_FOR_STRUCT_RETURN - Return LLVM Type if TY can  
>> be
>> +// returned as a scalar, otherwise return NULL.
>> +#ifndef LLVM_SCALAR_TYPE_FOR_STRUCT_RETURN
>> +#define LLVM_SCALAR_TYPE_FOR_STRUCT_RETURN(X) \
>
> The argument is X but the comment says TY.
>
>> +// LLVM_AGGR_TYPE_FOR_STRUCT_RETURN - Return LLVM Type if TY can be
>> +// returned as an aggregate, otherwise return NULL.
>> +#ifndef LLVM_AGGR_TYPE_FOR_STRUCT_RETURN
>> +#define LLVM_AGGR_TYPE_FOR_STRUCT_RETURN(X) \
>
> Likewise.
>
> Ciao,
>
> Duncan.
>




More information about the llvm-commits mailing list