[llvm-commits] [llvm] r49243 - /llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp

[Dale Johannesen]

On Apr 5, 2008, at 1:57 AM, Evan Cheng wrote:

> Is this fixing a regression from Dan's patch? Can you separate out the
> flushing functionality from getroot? It seems a bit strange to use
> getRoot for its side effects.
>
> Evan

Well, things named getXXX should not have side effects, IMO.  If I  
were going
to work on naming I would probably rename getRoot and getControlRoot  
to something
more descriptive rather than add a new function.  But in general I  
prefer minimal
changes to more invasive ones.  (I wasn't familiar with this code  
either.)

Glad this fixed some Ada regressions, not too surprising.