[llvm-commits] [llvm-gcc-4.2] r49231 - in /llvm-gcc-4.2/trunk/gcc: llvm-abi.h llvm-convert.cpp llvm-types.cpp

[Duncan Sands]

Hi Devang,

> +  /// HandleAggregateResultAsAggregate - This callback is invoked if the function
> +  /// ruturns an aggregate value using multiple return values.

ruturns -> returns
Same problem in the other comments.

> --- llvm-gcc-4.2/trunk/gcc/llvm-convert.cpp (original)
> +++ llvm-gcc-4.2/trunk/gcc/llvm-convert.cpp Fri Apr  4 16:15:06 2008
> @@ -2380,6 +2380,12 @@
>        // There is nothing to do here.
>      }
>  
> +    /// HandleAggregateResultAsAggregate - This callback is invoked if the function
> +    /// ruturns an aggregate value using multiple return values.
> +    void HandleAggregateResultAsAggregate(const Type *AggrTy) {
> +      // There is nothing to do here.
> +    }
> +
>      /// HandleAggregateShadowArgument - This callback is invoked if the function
>      /// returns an aggregate value by using a "shadow" first parameter.  If
>      /// RetPtr is set to true, the pointer argument itself is returned from the

The ABI is used in two places in llvm-convert: setting up arguments to calls,
and extracting arguments inside function bodies.  But you only modified one...

Ciao,

Duncan.