[llvm-commits] [llvm] r49123 - in /llvm/trunk/utils/TableGen: CodeGenDAGPatterns.cpp CodeGenDAGPatterns.h CodeGenIntrinsics.h CodeGenTarget.cpp CodeGenTarget.h DAGISelEmitter.h InstrInfoEmitter.cpp InstrInfoEmitter.h

[Chris Lattner]

On Apr 3, 2008, at 3:50 PM, Dan Gohman wrote:
> On Apr 3, 2008, at 12:27 AM, Duncan Sands wrote:
>> Hi,
>>
>>> +      fprintf(stderr,
>>> +              "Warning: mayStore flag explicitly set on
>>> instruction '%s'"
>>> +              " but flag already inferred from pattern.\n",
>>> +              Inst.TheDef->getName().c_str());
>>
>> should you be using fprintf for error reporting
>> (as opposed, for example, to cerr)?
>
> This was the original code; I just moved it from one file to
> another. fprintf seems as good as anything here to me though.

fwiw, I don't really mind fprintf.  C++ streams are pretty  
inefficient, and not always better than printf in terms of  
expressibility :(

-Chris