[llvm-commits] [llvm-gcc-4.2] r49015 - in /llvm-gcc-4.2/trunk/gcc: config/i386/llvm-i386-target.h llvm-abi.h

[Devang Patel]

On Mar 31, 2008, at 8:29 PM, Dale Johannesen wrote:

> On Mar 31, 2008, at 7:02 PM, Devang Patel wrote:
>
>> Author: dpatel
>> Date: Mon Mar 31 21:02:44 2008
>> New Revision: 49015
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=49015&view=rev
>> Log:
>> s/LLVM_SHOULD_RETURN_STRUCT_AS_SCALAR/
>> LLVM_SHOULD_RETURN_SELT_STRUCT_AS_SCALAR/g
>
> I don't like this one.  Structs that are returned as scalars are not,
> in fact, always single-element.

True, but this hook explicitly checks single-element. So it is a good  
idea to rename the hook to make this clear.

-
Devang
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20080401/c07eb608/attachment.html>