[llvm-commits] Speeding up instruction selection

[Dan Gohman]

Hi Roman,

On Mar 31, 2008, at 5:09 AM, Roman Levenstein wrote:
> Hi Dan, Hi Evan,
>
> Here is the updated patch.
>
> 1) I introduced the SDOperandPtr class, as I suggested in my last
> email. This class is a sort of an "intelligent" pointer. With this
> class, there is no need to copy the SDOperand arrays into the
> temporary SmallVectors. Therefore there is no additional overhead.

Ok. I actually prefer the temporary SmallVectors approach; they
incurred extra overhead when needed, while the SDOperandPtr
approach spreads out overhead to a wider extent. But I don't
think it's a big deal either way.

> 2) Additionally, I also finally made SDOperand a member of the SDUse,
> instead of using it as a base class. Now we can be sure that no
> unintentional conversion of SDUse into SDOperand happens.

Cool.

> 3) I also changed the return types of some methods from SDUse to
> SDOperand, as it was suggested during the review.

Cool.

> This patch passes all DejaGnu tests.

Ok. I'm a bit busy at the moment; I'll be doing more work on
this and your other patches hopefully soon.

Dan