[llvm-commits] [llvm] r48974 - /llvm/trunk/Makefile.config.in

[Gordon Henriksen]

Hi Erick,

Please run 'make check' before committing. I reverted this because it  
broke same; see PR2183.

I'd love it if spaces in pathnames worked, too, but in general spaces  
+ make = lose. The user in question has several options. He can:

1. --enable-bindings=none
2. Put an ocaml installation in his path, at a location with no spaces.
3. Use ./configure OCAMLDEP=... OCAMLC=... OCAMLOPT=... OCAMLDOC=...  
to specify executables with no spaces in their path.

Thanks,
Gordon


On Mar 30, 2008, at 23:46, Erick Tryzelaar wrote:

> Author: erickt
> Date: Sun Mar 30 22:46:43 2008
> New Revision: 48974
>
> URL: http://llvm.org/viewvc/llvm-project?rev=48974&view=rev
> Log:
> Quote the ocaml executables
>
> realazthat in #llvm was having problems building llvm
> because configure was finding an ocaml executable in
> a directory with a space in it's name. This patch
> puts quotes around the name so that llvm can build for
> him.
>
> Modified:
>    llvm/trunk/Makefile.config.in
>
> Modified: llvm/trunk/Makefile.config.in
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/Makefile.config.in?rev=48974&r1=48973&r2=48974&view=diff
>
> = 
> = 
> = 
> = 
> = 
> = 
> = 
> = 
> ======================================================================
> --- llvm/trunk/Makefile.config.in (original)
> +++ llvm/trunk/Makefile.config.in Sun Mar 30 22:46:43 2008
> @@ -151,10 +151,10 @@
> DOXYGEN    := @DOXYGEN@
> GROFF      := @GROFF@
> GZIP       := @GZIP@
> -OCAMLC     := @OCAMLC@
> -OCAMLOPT   := @OCAMLOPT@
> -OCAMLDEP   := @OCAMLDEP@
> -OCAMLDOC   := @OCAMLDOC@
> +OCAMLC     := "@OCAMLC@"
> +OCAMLOPT   := "@OCAMLOPT@"
> +OCAMLDEP   := "@OCAMLDEP@"
> +OCAMLDOC   := "@OCAMLDOC@"
> POD2HTML   := @POD2HTML@
> POD2MAN    := @POD2MAN@
> RUNTEST    := @RUNTEST@
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits