[llvm-commits] Helper methods

Chris Lattner clattner at apple.com
Tue Mar 18 22:07:52 PDT 2008


On Mar 18, 2008, at 11:04 AM, David Chisnall wrote:

> Hi,
>
> here are the two helper methods I mentioned on IRC.

Looks great, I applied it with some minor tweaks:
http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20080317/059876.html

The changes (FYI):

1. I used END_WITH_NULL on the variadic method so that GCC warns about  
StructType::get(type, 0) which is incorrect on 64-bit systems.
2. I changed CreateStructGEP to take the index as unsigned instead of  
signed int.
3. stdarg.h -> cstdarg.h

Thanks a lot, this is good stuff.  I'm going to go simplify clang to  
use them :)

-Chris



More information about the llvm-commits mailing list