[llvm-commits] [llvm] r48340 - in /llvm/trunk: include/llvm/System/DynamicLibrary.h lib/System/DynamicLibrary.cpp
Devang Patel
dpatel at apple.com
Thu Mar 13 09:55:34 PDT 2008
Author: dpatel
Date: Thu Mar 13 11:55:34 2008
New Revision: 48340
URL: http://llvm.org/viewvc/llvm-project?rev=48340&view=rev
Log:
Remove unused GetAddressOfSymbol()
Thanks Daniel Dunbar!
Modified:
llvm/trunk/include/llvm/System/DynamicLibrary.h
llvm/trunk/lib/System/DynamicLibrary.cpp
Modified: llvm/trunk/include/llvm/System/DynamicLibrary.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/System/DynamicLibrary.h?rev=48340&r1=48339&r2=48340&view=diff
==============================================================================
--- llvm/trunk/include/llvm/System/DynamicLibrary.h (original)
+++ llvm/trunk/include/llvm/System/DynamicLibrary.h Thu Mar 13 11:55:34 2008
@@ -38,19 +38,13 @@
public:
/// Construct a DynamicLibrary that represents the currently executing
/// program. The program must have been linked with -export-dynamic or
- /// -dlopen self for this to work. Any symbols retrieved with the
- /// GetAddressOfSymbol function will refer to the program not to any
- /// library.
+ /// -dlopen self for this to work.
/// @throws std::string indicating why the program couldn't be opened.
/// @brief Open program as dynamic library.
DynamicLibrary();
/// After destruction, the symbols of the library will no longer be
- /// available to the program. It is important to make sure the lifespan
- /// of a DynamicLibrary exceeds the lifetime of the pointers returned
- /// by the GetAddressOfSymbol otherwise the program may walk off into
- /// uncharted territory.
- /// @see GetAddressOfSymbol.
+ /// available to the program.
/// @brief Closes the DynamicLibrary
~DynamicLibrary();
@@ -92,26 +86,9 @@
}
/// @}
- /// @name Accessors
- /// @{
- public:
- /// Looks up a \p symbolName in the DynamicLibrary and returns its address
- /// if it exists. If the symbol does not exist, returns (void*)0.
- /// @returns the address of the symbol or 0.
- /// @brief Get the address of a symbol in the DynamicLibrary.
- void* GetAddressOfSymbol(const char* symbolName);
-
- /// @brief Convenience function for C++ophiles.
- void* GetAddressOfSymbol(const std::string& symbolName) {
- return GetAddressOfSymbol(symbolName.c_str());
- }
-
- /// @}
/// @name Implementation
/// @{
protected:
- void* handle; // Opaque handle for information about the library
-
DynamicLibrary(const DynamicLibrary&); ///< Do not implement
DynamicLibrary& operator=(const DynamicLibrary&); ///< Do not implement
/// @}
Modified: llvm/trunk/lib/System/DynamicLibrary.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/System/DynamicLibrary.cpp?rev=48340&r1=48339&r2=48340&view=diff
==============================================================================
--- llvm/trunk/lib/System/DynamicLibrary.cpp (original)
+++ llvm/trunk/lib/System/DynamicLibrary.cpp Thu Mar 13 11:55:34 2008
@@ -50,7 +50,7 @@
//static std::vector<lt_dlhandle> OpenedHandles;
static std::vector<void *> OpenedHandles;
-DynamicLibrary::DynamicLibrary() : handle(0) {}
+DynamicLibrary::DynamicLibrary() {}
DynamicLibrary::~DynamicLibrary() {
while(!OpenedHandles.empty()) {
@@ -158,11 +158,6 @@
return 0;
}
-void *DynamicLibrary::GetAddressOfSymbol(const char *symbolName) {
- assert(handle != 0 && "Invalid DynamicLibrary handle");
- return dlsym(handle, symbolName);
-}
-
#endif // LLVM_ON_WIN32
DEFINING_FILE_FOR(SystemDynamicLibrary)
More information about the llvm-commits
mailing list