[llvm-commits] [llvm] r48255 - in /llvm/trunk: include/llvm/GlobalAlias.h lib/VMCore/Globals.cpp
Duncan Sands
baldrick at free.fr
Wed Mar 12 00:46:04 PDT 2008
Hi Anton,
> + /// resolveAliasedGlobal() - This method tries to ultimately resolve alias by
resolve alias -> resolve the alias
> + /// going through aliasing chain and trying to find the very last
through aliasing chain -> through the aliasing chain
> + /// global. Return NULL is cycle was found.
Two spaces after full stop.
Return NULL is cycle was found -> Returns NULL if a cycle was found
> + SmallPtrSet<const GlobalValue*, 1> Visited;
Is using 1 here a good idea? It doesn't hurt and may help to use a
small but larger number.
Ciao,
Duncan.
More information about the llvm-commits
mailing list