[llvm-commits] [llvm] r48084 - in /llvm/trunk: lib/Transforms/IPO/PruneEH.cpp test/Transforms/PruneEH/unwindto.ll

[Nick Lewycky]

Author: nicholas
Date: Sat Mar  8 22:55:16 2008
New Revision: 48084

URL: http://llvm.org/viewvc/llvm-project?rev=48084&view=rev
Log:
Prune the unwind_to labels on BBs that don't need them. Another step in the
removal of invoke, PR1269.

Added:
    llvm/trunk/test/Transforms/PruneEH/unwindto.ll
Modified:
    llvm/trunk/lib/Transforms/IPO/PruneEH.cpp

Modified: llvm/trunk/lib/Transforms/IPO/PruneEH.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/IPO/PruneEH.cpp?rev=48084&r1=48083&r2=48084&view=diff

==============================================================================
--- llvm/trunk/lib/Transforms/IPO/PruneEH.cpp (original)
+++ llvm/trunk/lib/Transforms/IPO/PruneEH.cpp Sat Mar  8 22:55:16 2008
@@ -32,6 +32,7 @@
 
 STATISTIC(NumRemoved, "Number of invokes removed");
 STATISTIC(NumUnreach, "Number of noreturn calls optimized");
+STATISTIC(NumBBUnwind, "Number of unwind_to removed from blocks");
 
 namespace {
   struct VISIBILITY_HIDDEN PruneEH : public CallGraphSCCPass {
@@ -153,6 +154,8 @@
 bool PruneEH::SimplifyFunction(Function *F) {
   bool MadeChange = false;
   for (Function::iterator BB = F->begin(), E = F->end(); BB != E; ++BB) {
+    bool couldUnwind = false;
+
     if (InvokeInst *II = dyn_cast<InvokeInst>(BB->getTerminator()))
       if (II->doesNotThrow()) {
         SmallVector<Value*, 8> Args(II->op_begin()+3, II->op_end());
@@ -182,10 +185,11 @@
 
         ++NumRemoved;
         MadeChange = true;
-      }
+      } else
+        couldUnwind = true;
 
     for (BasicBlock::iterator I = BB->begin(), E = BB->end(); I != E; )
-      if (CallInst *CI = dyn_cast<CallInst>(I++))
+      if (CallInst *CI = dyn_cast<CallInst>(I++)) {
         if (CI->doesNotReturn() && !isa<UnreachableInst>(I)) {
           // This call calls a function that cannot return.  Insert an
           // unreachable instruction after it and simplify the code.  Do this
@@ -201,8 +205,17 @@
           MadeChange = true;
           ++NumUnreach;
           break;
-        }
+        } else if (!CI->doesNotThrow())
+          couldUnwind = true;
+      }
 
+    // Strip 'unwindTo' off of BBs that have no calls/invokes without nounwind.
+    if (!couldUnwind && BB->getUnwindDest()) {
+      MadeChange = true;
+      ++NumBBUnwind;
+      BB->getUnwindDest()->removePredecessor(BB, false, true);
+      BB->setUnwindDest(NULL);
+    }
   }
   return MadeChange;
 }

Added: llvm/trunk/test/Transforms/PruneEH/unwindto.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Transforms/PruneEH/unwindto.ll?rev=48084&view=auto

==============================================================================
--- llvm/trunk/test/Transforms/PruneEH/unwindto.ll (added)
+++ llvm/trunk/test/Transforms/PruneEH/unwindto.ll Sat Mar  8 22:55:16 2008
@@ -0,0 +1,15 @@
+; RUN: llvm-as < %s | opt -prune-eh | llvm-dis | not grep unwind_to
+
+define i8 @test7(i1 %b) {
+entry: unwind_to %cleanup
+  br i1 %b, label %cond_true, label %cond_false
+cond_true: unwind_to %cleanup
+  br label %cleanup
+cond_false: unwind_to %cleanup
+  br label %cleanup
+cleanup:
+  %x = phi i8 [0, %entry], [1, %cond_true], [1, %cond_true],
+                           [2, %cond_false], [2, %cond_false]
+  ret i8 %x
+}
+