[llvm-commits] [llvm] r48042 - in /llvm/trunk: include/llvm/CodeGen/ lib/CodeGen/SelectionDAG/ lib/Target/ lib/Target/ARM/ lib/Target/Alpha/ lib/Target/CellSPU/ lib/Target/IA64/ lib/Target/Mips/ lib/Target/PowerPC/ lib/Target/Sparc/ lib/Target/X86/ test/CodeGen/X86/

[Chris Lattner]

On Mar 7, 2008, at 4:58 PM, Evan Cheng wrote:

> =
> =
> =
> =
> =
> =
> =
> =
> ======================================================================
> --- llvm/trunk/lib/Target/ARM/ARMISelLowering.cpp (original)
> +++ llvm/trunk/lib/Target/ARM/ARMISelLowering.cpp Fri Mar  7  
> 18:58:38 2008
> @@ -211,6 +211,7 @@
>   setOperationAction(ISD::STACKRESTORE,       MVT::Other, Expand);
>   setOperationAction(ISD::DYNAMIC_STACKALLOC, MVT::i32  , Expand);
>   setOperationAction(ISD::MEMBARRIER        , MVT::Other, Expand);
> +  setOperationAction(ISD::PREFETCH          , MVT::Other, Expand);

Instead of setting PREFETCH to expand for every target, how about  
setting it to expand in the TargetISelLowering base class, and having  
the X86 target set it to legal?  For things that are illegal on most  
targets, I think it's a better way to go.

-Chris