[llvm-commits] [llvm] r47895 - in /llvm/trunk: include/llvm/DerivedTypes.h lib/VMCore/Type.cpp

[Devang Patel]

On Mar 4, 2008, at 1:17 PM, Chris Lattner wrote:

>>>> URL: http://llvm.org/viewvc/llvm-project?rev=47895&view=rev
>>>> Log:
>>>> Add FunctionType ctor variant that takes SmallVector params.
>>>>
>>>>
>>>> #include "llvm/Type.h"
>>>> +#include "llvm/ADT/SmallVector.h"
>>>
>>> Instead of making this specific to smallvector, how about passing in
>>> pointer to pointer + count instead?  That eliminates the #include  
>>> and
>>> allows it to work with arrays on the stack and scalars.
>>
>> I will do that conversion also. I did not do it immediately because  
>> it
>> required many mechanical changes.
>
> Just start using it where you would use the smallvector one, other
> existing clients don't need to change.  I'd really like to avoid
> DerivedTypes.h #including SmallVector.

My simplification run into something else, so I am not using  
SmallVector version right now. I just reverted this patch for now :)
-
Devang