[llvm-commits] Patch for review: Speeding up ScheduleDAG computations

[Tanya Lattner]

> Totally agree.
>
> Here is a proposed patch for ScheduleDAGRRList.cpp. It contains the
> following changes:
> 1) Uses std::set instead of the priority queue. This makes removal of
> nodes very fast and removes a bottleneck
> 2) sorting functions use now strict ordering
> 3) According to your proposal, it takes node priority updates into
> account and updates the priority queue by removing and re-inserting
> the updated element.
> 4) SumOfUnscheduledPredsOfSuccs is slightly changed to avoid useless
> computations. This saves a LOT OF time on big basic blocks.
>
> Please review and test, if possible. I have problems with running the
> llvm-test test-suite. When I to run it (and keep in mind, I never did
> it before), I always get the following error messages on my X86/Ubuntu
> system:
>  make[4]: *** No rule to make target
> `Output/sse.expandfft.linked.rbc', needed by
> `Output/sse.expandfft.linked.bc'.  Stop.
>
>

Please keep in mind that all proposed patches should have been tested  
before submitting. This includes llvm-test and 'make check'.
http://llvm.org/docs/DeveloperPolicy.html#quality

This will make Evan's job easier ;)

As for the error in llvm-test that you are seeing, can you use 'make  
VERBOSE=1 TEST=nightly report' and post more details on what make is  
running? It looks like an error in configuration. Did you reconfigure  
once you set llvm-gcc path?

Thanks,
Tanya



-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20080303/c9452d9b/attachment.html>