[llvm-commits] [llvm] r47594 - /llvm/trunk/lib/Target/X86/X86ISelLowering.cpp

[Evan Cheng]

That's a good idea. The key point is, please refactor the code! :-)

Evan

On Feb 26, 2008, at 10:48 AM, Anton Korobeynikov wrote:

>
>> Please combine the if (...) } else if (...) { to
>> if (!Is64Bit && getTargetMachine().getRelocationModel() ==  
>> Reloc::PIC_
>> && Subtarget->isPICStyleGot()) {
>>   if (!IsTailCall) {
>>   } else {
>>   }
>> }
>>
> Maybe it will be better to provide separate predicates for such stuff?
>
> -- 
> With best regards, Anton Korobeynikov.
>
> Faculty of Mathematics & Mechanics, Saint Petersburg State University.
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits