[llvm-commits] [llvm] r47554 - /llvm/trunk/lib/Target/X86/X86ISelLowering.cpp

[Dale Johannesen]

On Feb 25, 2008, at 11:52 AM, Evan Cheng wrote:
>>
>> +i) {
>> +        if (ChainVal->getOperand(i).Val == St->getValue().Val) {
>> +          if (TokenFactorIndex != -1)
>> +            return SDOperand();
>
> Is it necessary to abort the optimization here? You are creating a new
> TokenFactor node below, right? Why not just trim it? Perhaps
> SelectionDAG::getNode should ensure TokenFactor nodes do have
> duplicate operands?

Fair enough, I'll fix that.  I'm not sure this can arise in practice,  
I haven't seen it.