[llvm-commits] [llvm] r47469 - /llvm/trunk/include/llvm/CodeGen/SelectionDAGNodes.h
Chris Lattner
clattner at apple.com
Thu Feb 21 20:41:05 PST 2008
On Feb 21, 2008, at 6:28 PM, Dan Gohman wrote:
>
> On Feb 21, 2008, at 5:54 PM, Chris Lattner wrote:
>
>>
>> + const SDOperand &getBasePtr() const {
>> return getOperand(getOpcode() == ISD::LOAD ? 1 : 2);
>> }
>> - const SDOperand getOffset() const {
>> - return getOperand(getOpcode() == ISD::LOAD ? 2 : 3);
>> - }
>
> Why remove LSBaseSDNode::getOffset? Admittedly it wasn't used in
> many places, but it allowed the offset assertion check to live in
> LSBaseSDNode instead of being in both Load and Store.
I don't have a strong opinion about it, but it seemed like all users
had information about which node they had, so they could avoid the
dynamic check. If you prefer I can add it back,
-Chris
More information about the llvm-commits
mailing list