[llvm-commits] [llvm] r47399 - /llvm/trunk/lib/CodeGen/LiveVariables.cpp
Bill Wendling
isanbard at gmail.com
Wed Feb 20 12:56:45 PST 2008
Author: void
Date: Wed Feb 20 14:56:45 2008
New Revision: 47399
URL: http://llvm.org/viewvc/llvm-project?rev=47399&view=rev
Log:
Remove one of the fixmes that I put in there. From Evan:
No need to go up more levels. A def of a register also sets its sub-registers
(so if PhysRegInfo[SuperReg] is NULL, it means SuperReg's super registers are
not previously defined).
Modified:
llvm/trunk/lib/CodeGen/LiveVariables.cpp
Modified: llvm/trunk/lib/CodeGen/LiveVariables.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/LiveVariables.cpp?rev=47399&r1=47398&r2=47399&view=diff
==============================================================================
--- llvm/trunk/lib/CodeGen/LiveVariables.cpp (original)
+++ llvm/trunk/lib/CodeGen/LiveVariables.cpp Wed Feb 20 14:56:45 2008
@@ -258,8 +258,9 @@
bool HasPrevDef = PhysRegInfo[SuperReg] != NULL;
if (!HasPrevDef)
- // FIXME: This only goes back one level of super-registers. It might miss
- // some.
+ // No need to go up more levels. A def of a register also sets its sub-
+ // registers. So if PhysRegInfo[SuperReg] is NULL, it means SuperReg's
+ // super-registers are not previously defined.
for (const unsigned *SSRegs = RegInfo->getSuperRegisters(SuperReg);
unsigned SSReg = *SSRegs; ++SSRegs)
if (PhysRegInfo[SSReg] != NULL) {
More information about the llvm-commits
mailing list