[llvm-commits] [llvm] r47387 - /llvm/trunk/lib/VMCore/Verifier.cpp

[Chris Lattner]

On Feb 20, 2008, at 10:36 AM, Devang Patel wrote:

> Author: dpatel
> Date: Wed Feb 20 12:36:46 2008
> New Revision: 47387
>
> URL: http://llvm.org/viewvc/llvm-project?rev=47387&view=rev
> Log:
> Use isValidOperands() to verify GetResultInst.

The verifier should use the Assert1 macro.  It wants to report an  
error and continue, not abort.

-Chris

>
>
> Modified:
>    llvm/trunk/lib/VMCore/Verifier.cpp
>
> Modified: llvm/trunk/lib/VMCore/Verifier.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/VMCore/Verifier.cpp?rev=47387&r1=47386&r2=47387&view=diff
>
> = 
> = 
> = 
> = 
> = 
> = 
> = 
> = 
> ======================================================================
> --- llvm/trunk/lib/VMCore/Verifier.cpp (original)
> +++ llvm/trunk/lib/VMCore/Verifier.cpp Wed Feb 20 12:36:46 2008
> @@ -1039,7 +1039,8 @@
> }
>
> void Verifier::visitGetResultInst(GetResultInst &GRI) {
> -  // FIXME : Check operands.
> +  assert (GRI.isValidOperands(GRI.getAggregateValue(),  
> GRI.getIndex())
> +          && "Invalid GetResultInst operands!");
>   visitInstruction(GRI);
> }
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits