[llvm-commits] [llvm] r47323 - in /llvm/trunk: include/llvm/LinkAllPasses.h include/llvm/Transforms/Scalar.h lib/Transforms/Utils/LowerAllocations.cpp lib/Transforms/Utils/LowerInvoke.cpp lib/Transforms/Utils/LowerSelect.cpp lib/Transforms/Utils/LowerSwitch.cpp lib/Transforms/Utils/Mem2Reg.cpp lib/Transforms/Utils/UnifyFunctionExitNodes.cpp
Chris Lattner
sabre at nondot.org
Mon Feb 18 23:49:17 PST 2008
Author: lattner
Date: Tue Feb 19 01:49:17 2008
New Revision: 47323
URL: http://llvm.org/viewvc/llvm-project?rev=47323&view=rev
Log:
remove the LowerSelect pass. The last client was the old Sparc backend, which is long dead by now.
Removed:
llvm/trunk/lib/Transforms/Utils/LowerSelect.cpp
Modified:
llvm/trunk/include/llvm/LinkAllPasses.h
llvm/trunk/include/llvm/Transforms/Scalar.h
llvm/trunk/lib/Transforms/Utils/LowerAllocations.cpp
llvm/trunk/lib/Transforms/Utils/LowerInvoke.cpp
llvm/trunk/lib/Transforms/Utils/LowerSwitch.cpp
llvm/trunk/lib/Transforms/Utils/Mem2Reg.cpp
llvm/trunk/lib/Transforms/Utils/UnifyFunctionExitNodes.cpp
Modified: llvm/trunk/include/llvm/LinkAllPasses.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/LinkAllPasses.h?rev=47323&r1=47322&r2=47323&view=diff
==============================================================================
--- llvm/trunk/include/llvm/LinkAllPasses.h (original)
+++ llvm/trunk/include/llvm/LinkAllPasses.h Tue Feb 19 01:49:17 2008
@@ -84,7 +84,6 @@
(void) llvm::createLoopIndexSplitPass();
(void) llvm::createLowerAllocationsPass();
(void) llvm::createLowerInvokePass();
- (void) llvm::createLowerSelectPass();
(void) llvm::createLowerSetJmpPass();
(void) llvm::createLowerSwitchPass();
(void) llvm::createNoAAPass();
Modified: llvm/trunk/include/llvm/Transforms/Scalar.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Transforms/Scalar.h?rev=47323&r1=47322&r2=47323&view=diff
==============================================================================
--- llvm/trunk/include/llvm/Transforms/Scalar.h (original)
+++ llvm/trunk/include/llvm/Transforms/Scalar.h Tue Feb 19 01:49:17 2008
@@ -231,15 +231,6 @@
//===----------------------------------------------------------------------===//
//
-// LowerSelect - This pass converts SelectInst instructions into conditional
-// branch and PHI instructions. If the OnlyFP flag is set to true, then only
-// floating point select instructions are lowered.
-//
-FunctionPass *createLowerSelectPass(bool OnlyFP = false);
-extern const PassInfo *LowerSelectID;
-
-//===----------------------------------------------------------------------===//
-//
// LowerAllocations - Turn malloc and free instructions into %malloc and %free
// calls.
//
Modified: llvm/trunk/lib/Transforms/Utils/LowerAllocations.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Utils/LowerAllocations.cpp?rev=47323&r1=47322&r2=47323&view=diff
==============================================================================
--- llvm/trunk/lib/Transforms/Utils/LowerAllocations.cpp (original)
+++ llvm/trunk/lib/Transforms/Utils/LowerAllocations.cpp Tue Feb 19 01:49:17 2008
@@ -48,7 +48,6 @@
// This is a cluster of orthogonal Transforms:
AU.addPreserved<UnifyFunctionExitNodes>();
AU.addPreservedID(PromoteMemoryToRegisterID);
- AU.addPreservedID(LowerSelectID);
AU.addPreservedID(LowerSwitchID);
AU.addPreservedID(LowerInvokePassID);
}
Modified: llvm/trunk/lib/Transforms/Utils/LowerInvoke.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Utils/LowerInvoke.cpp?rev=47323&r1=47322&r2=47323&view=diff
==============================================================================
--- llvm/trunk/lib/Transforms/Utils/LowerInvoke.cpp (original)
+++ llvm/trunk/lib/Transforms/Utils/LowerInvoke.cpp Tue Feb 19 01:49:17 2008
@@ -84,7 +84,6 @@
virtual void getAnalysisUsage(AnalysisUsage &AU) const {
// This is a cluster of orthogonal Transforms
AU.addPreservedID(PromoteMemoryToRegisterID);
- AU.addPreservedID(LowerSelectID);
AU.addPreservedID(LowerSwitchID);
AU.addPreservedID(LowerAllocationsID);
}
Removed: llvm/trunk/lib/Transforms/Utils/LowerSelect.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Utils/LowerSelect.cpp?rev=47322&view=auto
==============================================================================
--- llvm/trunk/lib/Transforms/Utils/LowerSelect.cpp (original)
+++ llvm/trunk/lib/Transforms/Utils/LowerSelect.cpp (removed)
@@ -1,105 +0,0 @@
-//===- LowerSelect.cpp - Transform select insts to branches ---------------===//
-//
-// The LLVM Compiler Infrastructure
-//
-// This file is distributed under the University of Illinois Open Source
-// License. See LICENSE.TXT for details.
-//
-//===----------------------------------------------------------------------===//
-//
-// This pass lowers select instructions into conditional branches for targets
-// that do not have conditional moves or that have not implemented the select
-// instruction yet.
-//
-// Note that this pass could be improved. In particular it turns every select
-// instruction into a new conditional branch, even though some common cases have
-// select instructions on the same predicate next to each other. It would be
-// better to use the same branch for the whole group of selects.
-//
-//===----------------------------------------------------------------------===//
-
-#include "llvm/Transforms/Scalar.h"
-#include "llvm/Transforms/Utils/UnifyFunctionExitNodes.h"
-#include "llvm/Function.h"
-#include "llvm/Instructions.h"
-#include "llvm/Pass.h"
-#include "llvm/Type.h"
-#include "llvm/Support/Compiler.h"
-using namespace llvm;
-
-namespace {
- /// LowerSelect - Turn select instructions into conditional branches.
- ///
- class VISIBILITY_HIDDEN LowerSelect : public FunctionPass {
- bool OnlyFP; // Only lower FP select instructions?
- public:
- static char ID; // Pass identification, replacement for typeid
- explicit LowerSelect(bool onlyfp = false) : FunctionPass((intptr_t)&ID),
- OnlyFP(onlyfp) {}
-
- virtual void getAnalysisUsage(AnalysisUsage &AU) const {
- // This certainly destroys the CFG.
- // This is a cluster of orthogonal Transforms:
- AU.addPreserved<UnifyFunctionExitNodes>();
- AU.addPreservedID(PromoteMemoryToRegisterID);
- AU.addPreservedID(LowerSwitchID);
- AU.addPreservedID(LowerInvokePassID);
- AU.addPreservedID(LowerAllocationsID);
- }
-
- bool runOnFunction(Function &F);
- };
-
- char LowerSelect::ID = 0;
- RegisterPass<LowerSelect>
- X("lowerselect", "Lower select instructions to branches");
-}
-
-// Publically exposed interface to pass...
-const PassInfo *llvm::LowerSelectID = X.getPassInfo();
-//===----------------------------------------------------------------------===//
-// This pass converts SelectInst instructions into conditional branch and PHI
-// instructions. If the OnlyFP flag is set to true, then only floating point
-// select instructions are lowered.
-//
-FunctionPass *llvm::createLowerSelectPass(bool OnlyFP) {
- return new LowerSelect(OnlyFP);
-}
-
-
-bool LowerSelect::runOnFunction(Function &F) {
- bool Changed = false;
- for (Function::iterator BB = F.begin(), E = F.end(); BB != E; ++BB)
- for (BasicBlock::iterator I = BB->begin(), E = BB->end(); I != E; ++I) {
- if (SelectInst *SI = dyn_cast<SelectInst>(I))
- if (!OnlyFP || SI->getType()->isFloatingPoint()) {
- // Split this basic block in half right before the select instruction.
- BasicBlock *NewCont =
- BB->splitBasicBlock(I, BB->getName()+".selectcont");
-
- // Make the true block, and make it branch to the continue block.
- BasicBlock *NewTrue = new BasicBlock(BB->getName()+".selecttrue",
- BB->getParent(), NewCont);
- new BranchInst(NewCont, NewTrue);
-
- // Make the unconditional branch in the incoming block be a
- // conditional branch on the select predicate.
- BB->getInstList().erase(BB->getTerminator());
- new BranchInst(NewTrue, NewCont, SI->getCondition(), BB);
-
- // Create a new PHI node in the cont block with the entries we need.
- PHINode *PN = new PHINode(SI->getType(), "", NewCont->begin());
- PN->takeName(SI);
- PN->addIncoming(SI->getTrueValue(), NewTrue);
- PN->addIncoming(SI->getFalseValue(), BB);
-
- // Use the PHI instead of the select.
- SI->replaceAllUsesWith(PN);
- NewCont->getInstList().erase(SI);
-
- Changed = true;
- break; // This block is done with.
- }
- }
- return Changed;
-}
Modified: llvm/trunk/lib/Transforms/Utils/LowerSwitch.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Utils/LowerSwitch.cpp?rev=47323&r1=47322&r2=47323&view=diff
==============================================================================
--- llvm/trunk/lib/Transforms/Utils/LowerSwitch.cpp (original)
+++ llvm/trunk/lib/Transforms/Utils/LowerSwitch.cpp Tue Feb 19 01:49:17 2008
@@ -40,7 +40,6 @@
// This is a cluster of orthogonal Transforms
AU.addPreserved<UnifyFunctionExitNodes>();
AU.addPreservedID(PromoteMemoryToRegisterID);
- AU.addPreservedID(LowerSelectID);
AU.addPreservedID(LowerInvokePassID);
AU.addPreservedID(LowerAllocationsID);
}
Modified: llvm/trunk/lib/Transforms/Utils/Mem2Reg.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Utils/Mem2Reg.cpp?rev=47323&r1=47322&r2=47323&view=diff
==============================================================================
--- llvm/trunk/lib/Transforms/Utils/Mem2Reg.cpp (original)
+++ llvm/trunk/lib/Transforms/Utils/Mem2Reg.cpp Tue Feb 19 01:49:17 2008
@@ -43,7 +43,6 @@
AU.setPreservesCFG();
// This is a cluster of orthogonal Transforms
AU.addPreserved<UnifyFunctionExitNodes>();
- AU.addPreservedID(LowerSelectID);
AU.addPreservedID(LowerSwitchID);
AU.addPreservedID(LowerInvokePassID);
AU.addPreservedID(LowerAllocationsID);
Modified: llvm/trunk/lib/Transforms/Utils/UnifyFunctionExitNodes.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Utils/UnifyFunctionExitNodes.cpp?rev=47323&r1=47322&r2=47323&view=diff
==============================================================================
--- llvm/trunk/lib/Transforms/Utils/UnifyFunctionExitNodes.cpp (original)
+++ llvm/trunk/lib/Transforms/Utils/UnifyFunctionExitNodes.cpp Tue Feb 19 01:49:17 2008
@@ -37,7 +37,6 @@
AU.addPreservedID(BreakCriticalEdgesID);
// This is a cluster of orthogonal Transforms
AU.addPreservedID(PromoteMemoryToRegisterID);
- AU.addPreservedID(LowerSelectID);
AU.addPreservedID(LowerSwitchID);
}
More information about the llvm-commits
mailing list