[llvm-commits] [llvm] r46916 - /llvm/trunk/lib/Target/PowerPC/PPCTargetAsmInfo.cpp

[Nick Lewycky]

Evan Cheng wrote:
> Any idea what the differences mean? .rodata.cst4 makes it possible to  
> be merged? Was there a reason to change it or than to match gcc?

You're right, this is a bad patch. I changed it because I was getting 
errors in the assembler with it, but then, that's not what changed to 
make the changes go away. You can revert the patch or I'll revert it later.

The problem goes away when EH is set to disabled. I'll collect the 
errors and email them later today.

Nick

> Thanks,
> 
> Evan
> 
> On Feb 9, 2008, at 4:03 PM, Nick Lewycky wrote:
> 
>> Author: nicholas
>> Date: Sat Feb  9 18:03:54 2008
>> New Revision: 46916
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=46916&view=rev
>> Log:
>> Match GCC's behaviour for these sections.
>>
>> Modified:
>>    llvm/trunk/lib/Target/PowerPC/PPCTargetAsmInfo.cpp
>>
>> Modified: llvm/trunk/lib/Target/PowerPC/PPCTargetAsmInfo.cpp
>> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/PowerPC/PPCTargetAsmInfo.cpp?rev=46916&r1=46915&r2=46916&view=diff
>>
>> = 
>> = 
>> = 
>> = 
>> = 
>> = 
>> = 
>> = 
>> ======================================================================
>> --- llvm/trunk/lib/Target/PowerPC/PPCTargetAsmInfo.cpp (original)
>> +++ llvm/trunk/lib/Target/PowerPC/PPCTargetAsmInfo.cpp Sat Feb  9  
>> 18:03:54 2008
>> @@ -92,8 +92,8 @@
>>   CommentString = "#";
>>   GlobalPrefix = "";
>>   PrivateGlobalPrefix = "";
>> -  ConstantPoolSection = "\t.section .rodata.cst4\t";
>> -  JumpTableDataSection = ".section .rodata.cst4";
>> +  ConstantPoolSection = "\t.section .rodata\t";
>> +  JumpTableDataSection = ".section .rodata";
>>   CStringSection = "\t.section\t.rodata";
>>   StaticCtorsSection = ".section\t.ctors,\"aw\", at progbits";
>>   StaticDtorsSection = ".section\t.dtors,\"aw\", at progbits";
>>
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>