[llvm-commits] [llvm] r46854 - /llvm/trunk/lib/Target/X86/X86ISelLowering.cpp

[Chris Lattner]

On Feb 7, 2008, at 8:28 AM, Dan Gohman wrote:
>   if (Flags & ISD::ParamFlags::ByVal) {
>     return CreateCopyOfByValArgument(Arg, PtrOff, Chain, Flags, DAG);
>   }
> -  return DAG.getStore(Chain, Arg, PtrOff, NULL, 0);
> +  return DAG.getStore(Chain, Arg, PtrOff,
> +                      &PseudoSourceValue::getStack(), LocMemOffset);
> }

Hey Dan,

Why not have getStack() return a Value* instead of Value&?  That would  
eliminate the '&'s and would be more consistent with other APIS,

-Chris