[llvm-commits] [llvm] r46666 - /llvm/trunk/lib/Target/X86/X86ISelLowering.cpp

[Nick Lewycky]

Chris Lattner wrote:
> On Feb 2, 2008, at 11:43 AM, Eric Christopher wrote:
> 
>> On Feb 2, 2008, at 11:13 AM, Chris Lattner wrote:
>>
>>> On Feb 2, 2008, at 12:29 AM, Nick Lewycky wrote:
>>>> Author: nicholas
>>>> Date: Sat Feb  2 02:29:58 2008
>>>> New Revision: 46666
>>>>
>>>> URL: http://llvm.org/viewvc/llvm-project?rev=46666&view=rev
>>>> Log:
>>>> Don't use uninitialized values. Fixes vec_align.ll on X86 Linux.
>>> Oooh excellent detective work, thanks Nick!
>> Don't compile with -Wuninitialized or did it not notice?
> 
> It didn't warn because the variable is being passed in by ref to a  
> function that conditionally initializes it.

Strictly speaking, the callee never initializes it either. It just uses 
+= on that uninitialized value. I don't know whether GCC is expected to 
do such deep analysis for its warnings.

Nick