[llvm-commits] [llvm] r46144 - in /llvm/trunk/lib/Target: PowerPC/PPCAsmPrinter.cpp X86/X86AsmPrinter.cpp

[Chris Lattner]

On Jan 18, 2008, at 10:19 AM, Dale Johannesen wrote:
> On Jan 18, 2008, at 10:13 AM, Tanya Lattner wrote:
>> Should the test/CodeGen/X86/aligned-comm.ll be un-XFAILED? Its now
>> XPASSing.
>>
>> -Tanya
>
> I guess so; given the current state of llvm it is supposed to pass.
> Longterm what should happen is that tentative definitions ("common")
> get represented differently in the IR than weak globals; when that
> happens the test will be incorrect (again).

The goal is to keep the tree in a state where all tests pass or  
xfail.  Please update the test, and if you commit something that  
breaks a test, please xfail it.  Thanks Dale,

-Chris