[llvm-commits] [llvm] r46144 - in /llvm/trunk/lib/Target: PowerPC/PPCAsmPrinter.cpp X86/X86AsmPrinter.cpp

[Evan Cheng]

Please revert the ARM changes as well. I am assuming the bug is there  
as well. :-)

Evan

On Jan 17, 2008, at 3:04 PM, Dale Johannesen wrote:

> Author: johannes
> Date: Thu Jan 17 17:04:07 2008
> New Revision: 46144
>
> URL: http://llvm.org/viewvc/llvm-project?rev=46144&view=rev
> Log:
> Revert the part of 45848 that treated weak globals
> as weak globals rather than commons.  While not wrong,
> this change tickled a latent bug in Darwin's strip,
> so revert it for now as a workaround.
>
>
> Modified:
>    llvm/trunk/lib/Target/PowerPC/PPCAsmPrinter.cpp
>    llvm/trunk/lib/Target/X86/X86AsmPrinter.cpp
>
> Modified: llvm/trunk/lib/Target/PowerPC/PPCAsmPrinter.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/PowerPC/PPCAsmPrinter.cpp?rev=46144&r1=46143&r2=46144&view=diff
>
> = 
> = 
> = 
> = 
> = 
> = 
> = 
> = 
> ======================================================================
> --- llvm/trunk/lib/Target/PowerPC/PPCAsmPrinter.cpp (original)
> +++ llvm/trunk/lib/Target/PowerPC/PPCAsmPrinter.cpp Thu Jan 17  
> 17:04:07 2008
> @@ -917,7 +917,8 @@
>
>     if (C->isNullValue() && /* FIXME: Verify correct */
>         !I->hasSection() &&
> -        (I->hasInternalLinkage() || I->hasExternalLinkage())) {
> +        (I->hasInternalLinkage() || I->hasWeakLinkage() ||
> +         I->hasLinkOnceLinkage() || I->hasExternalLinkage())) {
>       if (Size == 0) Size = 1;   // .comm Foo, 0 is undefined, avoid  
> it.
>       if (I->hasExternalLinkage()) {
>         O << "\t.globl " << name << '\n';
>
> Modified: llvm/trunk/lib/Target/X86/X86AsmPrinter.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86AsmPrinter.cpp?rev=46144&r1=46143&r2=46144&view=diff
>
> = 
> = 
> = 
> = 
> = 
> = 
> = 
> = 
> ======================================================================
> --- llvm/trunk/lib/Target/X86/X86AsmPrinter.cpp (original)
> +++ llvm/trunk/lib/Target/X86/X86AsmPrinter.cpp Thu Jan 17 17:04:07  
> 2008
> @@ -181,9 +181,8 @@
>       }
>
>       if (!I->isThreadLocal() &&
> -          (I->hasInternalLinkage() ||
> -           (!Subtarget->isTargetDarwin() &&
> -            (I->hasWeakLinkage() || I->hasLinkOnceLinkage())))) {
> +          (I->hasInternalLinkage() || I->hasWeakLinkage() ||
> +           I->hasLinkOnceLinkage())) {
>         if (Size == 0) Size = 1;   // .comm Foo, 0 is undefined,  
> avoid it.
>         if (!NoZerosInBSS && TAI->getBSSSection())
>           SwitchToDataSection(TAI->getBSSSection(), I);
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits