[llvm-commits] [llvm-gcc-4.2] r45978 - /llvm-gcc-4.2/trunk/gcc/objc/objc-act.c

[Chris Lattner]

On Jan 14, 2008, at 2:18 PM, Bill Wendling wrote:
> URL: http://llvm.org/viewvc/llvm-project?rev=45978&view=rev
> Log:
> GCC emits .reference and .lazy_reference directives directly to  
> the .s file. We
> rather create the reference as data and then point that to what we  
> then hope
> is an external symbol. However, this symbol doesn't have to exist in  
> some cases.
> And, even without the .reference and .lazy_reference directives, we  
> shouldn't
> be emitting data refering to this symbol.

More to the point, this improves compatibility with the leopard  
dynamic linker and xcode 3.0 linker.

I'll apply this to llvm-gcc 4.0 Bill, but please add the LLVM LOCAL  
markers to the new #ifdefs, thanks!

-Chris

>
>
> Modified:
>    llvm-gcc-4.2/trunk/gcc/objc/objc-act.c
>
> Modified: llvm-gcc-4.2/trunk/gcc/objc/objc-act.c
> URL: http://llvm.org/viewvc/llvm-project/llvm-gcc-4.2/trunk/gcc/objc/objc-act.c?rev=45978&r1=45977&r2=45978&view=diff
>
> = 
> = 
> = 
> = 
> = 
> = 
> = 
> = 
> ======================================================================
> --- llvm-gcc-4.2/trunk/gcc/objc/objc-act.c (original)
> +++ llvm-gcc-4.2/trunk/gcc/objc/objc-act.c Mon Jan 14 16:18:42 2008
> @@ -18255,19 +18255,15 @@
>   tree decl;
>   tree exp;
>
> -  /* LLVM LOCAL begin */
> -#ifdef ENABLE_LLVM
> -#undef ASM_DECLARE_UNRESOLVED_REFERENCE
> -#endif
> -  /* LLVM LOCAL end */
> -
>   sprintf (string, "%sobjc_class_name_%s",
> 	   (flag_next_runtime ? "." : "__"), name);
>
> #ifdef ASM_DECLARE_UNRESOLVED_REFERENCE
>   if (flag_next_runtime)
>     {
> +#ifndef ENABLE_LLVM
>       ASM_DECLARE_UNRESOLVED_REFERENCE (asm_out_file, string);
> +#endif
>       return;
>     }
> #endif
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits