[llvm-commits] Patch for compiling with Mingw/Cygwin

Alain Frisch alain at frisch.fr
Mon Jan 14 00:56:10 PST 2008


Hello,

Sorry for not replying before. I was not subscribed to llvm-commits and 
did not see your email.

> A couple of comments:  You really need to add some comments in  
> Makefile.config.in over the stuff that sets SYSPATH to indicate what  
> it is used for, and probably over the TableGen = ... line in  
> Makefile.rules.  If you don't do this, someone may break this in the  
> future.

Ok, done.

> Another thing: does it work to add something like this to  
> makefile.rules?
> 
> ifeq ($(OS),Cygwin)
>   USE_CYGPATH := true  # Actually, it would be better to do the  
> syspath stuff here and remove USE_CYGPATH
> endif

cygpath should only be used when compiling for Mingw under Cygwin (ie, 
the gcc -mno-cygwin). I've done that instead:

ifneq (,$(findstring -mno-cygwin, $(CXX)))
   SYSPATH = $(shell echo $(1) | cygpath -m -f -)
else
   SYSPATH = $(1)
endif


The new patch is attached.


-- Alain
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: diff
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20080114/6e6aebd5/attachment.ksh>


More information about the llvm-commits mailing list