[llvm-commits] [llvm-gcc-4.2] r45907 - in /llvm-gcc-4.2/trunk/gcc: llvm-abi.h llvm-convert.cpp llvm-types.cpp

[Evan Cheng]

On Jan 13, 2008, at 12:37 PM, Duncan Sands wrote:

> Hi Chris,
>
>> byval makes sense semantically for any pointer to sized type, I think
>> it would be reasonable to expand it to allow any of these pointers,
>> including the one above.
>
> I adjusted the check to allow pointers to arrays, but got a crash in
> SelectionDAGISel.cpp:
>
> 	if (F.paramHasAttr(j, ParamAttr::ByVal)) {
> 	  Flags |= ISD::ParamFlags::ByVal;
> 	  const PointerType *Ty = cast<PointerType>(I->getType());
> 	  const StructType *STy = cast<StructType>(Ty->getElementType());  
> <== HERE

Thanks. I see you have fixed the crash in SelectionDAGISel.cpp?

Evan

>
> Ciao,
>
> Duncan.
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits