[llvm-commits] [llvm-gcc-4.2] r45757 - in /llvm-gcc-4.2/trunk/gcc: llvm-types.cpp tree.c tree.h

[Chris Lattner]

On Jan 8, 2008, at 1:08 PM, Dale Johannesen wrote:
> URL: http://llvm.org/viewvc/llvm-project?rev=45757&view=rev
> Log:
> Fix gcc->llvm translation for virtual base classes.  pr1746

Yay, very nice Dale.

> +/// Mapping from type to type-used-as-base-class and back.
> +static DenseMap<tree, tree> BaseTypesMap;

Does this play well with PCH?  Please add a comment above this that  
says that the trees are kept pinned for the GC by the llvm_types_used  
map.

If this doesn't work with PCH (Devang, thoughts?) it might be better  
to use the GCC splay tree or whatever they use for tree->tree mappings.

Thanks for tackling this Dale,

-Chris