[llvm-commits] [llvm] r45746 - in /llvm/trunk/lib/Target: PowerPC/PPCSubtarget.cpp X86/X86Subtarget.cpp

[Duncan Sands]

Author: baldrick
Date: Tue Jan  8 04:06:15 2008
New Revision: 45746

URL: http://llvm.org/viewvc/llvm-project?rev=45746&view=rev
Log:
Use size_t to store Pos, avoid truncating value
on 64-bit builds.  Analysis and original patch
by Török Edwin.  Code audit found another place
with the same problem, also fixed here.

Modified:
    llvm/trunk/lib/Target/PowerPC/PPCSubtarget.cpp
    llvm/trunk/lib/Target/X86/X86Subtarget.cpp

Modified: llvm/trunk/lib/Target/PowerPC/PPCSubtarget.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/PowerPC/PPCSubtarget.cpp?rev=45746&r1=45745&r2=45746&view=diff

==============================================================================
--- llvm/trunk/lib/Target/PowerPC/PPCSubtarget.cpp (original)
+++ llvm/trunk/lib/Target/PowerPC/PPCSubtarget.cpp Tue Jan  8 04:06:15 2008
@@ -103,7 +103,7 @@
   const std::string &TT = M.getTargetTriple();
   if (TT.length() > 7) {
     // Determine which version of darwin this is.
-    unsigned DarwinPos = TT.find("-darwin");
+    size_t DarwinPos = TT.find("-darwin");
     if (DarwinPos != std::string::npos) {
       if (isdigit(TT[DarwinPos+7]))
         DarwinVers = atoi(&TT[DarwinPos+7]);

Modified: llvm/trunk/lib/Target/X86/X86Subtarget.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86Subtarget.cpp?rev=45746&r1=45745&r2=45746&view=diff

==============================================================================
--- llvm/trunk/lib/Target/X86/X86Subtarget.cpp (original)
+++ llvm/trunk/lib/Target/X86/X86Subtarget.cpp Tue Jan  8 04:06:15 2008
@@ -257,7 +257,7 @@
   // if one cannot be determined, to true.
   const std::string& TT = M.getTargetTriple();
   if (TT.length() > 5) {
-    unsigned Pos;
+    size_t Pos;
     if ((Pos = TT.find("-darwin")) != std::string::npos) {
       TargetType = isDarwin;