[llvm-commits] [llvm] r45221 - /llvm/trunk/lib/Target/PowerPC/PPCTargetAsmInfo.cpp

[Duncan Sands]

> > The EH will work (modulo bugs) if you pass -enable-eh; however,
> > the top-level Makefile currently sets -enable-correct-eh-support.
> 
> What is the difference these days?  Should the top-level makefile be  
> changed?

They are not at all the same: -enable-eh turns on dwarf eh support,
while -enable-correct-eh-support turns on sj/lj lowering.  If you
turn on both than you get -enable-eh on all targets, whether or not
it supports dwarf eh (check out LLVMTargetMachine.cpp: the LowerInvoke
pass is only scheduled if -enable-eh is not turned on).  This is kind
of problematic because in the testsuite we really want: -enable-eh on
targets that support dwarf eh, and -enable-correct-eh-support otherwise.
Presumably what needs to be done is: pass both options in the Makefile,
and schedule a LowerInvoke pass if the target does not support dwarf eh
or -enable-eh is not turned on.  (The LowerInvoke pass itself returns
without doing anything if -enable-correct-eh-support is not turned on).

Ciao,

Duncan.