[llvm-commits] [llvm] r45147 - in /llvm/trunk: lib/VMCore/AsmWriter.cpp test/Bindings/Ocaml/vmcore.ml

Christopher Lamb christopher.lamb at gmail.com
Mon Dec 17 19:49:36 PST 2007


Author: clamb
Date: Mon Dec 17 21:49:35 2007
New Revision: 45147

URL: http://llvm.org/viewvc/llvm-project?rev=45147&view=rev
Log:
Don't forget to print address space qualifiers when printing out the type table! Thanks to Gordon Henriksen for pointing this out.

Modified:
    llvm/trunk/lib/VMCore/AsmWriter.cpp
    llvm/trunk/test/Bindings/Ocaml/vmcore.ml

Modified: llvm/trunk/lib/VMCore/AsmWriter.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/VMCore/AsmWriter.cpp?rev=45147&r1=45146&r2=45147&view=diff

==============================================================================
--- llvm/trunk/lib/VMCore/AsmWriter.cpp (original)
+++ llvm/trunk/lib/VMCore/AsmWriter.cpp Mon Dec 17 21:49:35 2007
@@ -808,7 +808,10 @@
     if (STy->isPacked())
       Out << '>';
   } else if (const PointerType *PTy = dyn_cast<PointerType>(Ty)) {
-    printType(PTy->getElementType()) << '*';
+    printType(PTy->getElementType());
+    if (unsigned AddressSpace = PTy->getAddressSpace())
+      Out << " addrspace(" << AddressSpace << ")";
+    Out << '*';
   } else if (const ArrayType *ATy = dyn_cast<ArrayType>(Ty)) {
     Out << '[' << ATy->getNumElements() << " x ";
     printType(ATy->getElementType()) << ']';

Modified: llvm/trunk/test/Bindings/Ocaml/vmcore.ml
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Bindings/Ocaml/vmcore.ml?rev=45147&r1=45146&r2=45147&view=diff

==============================================================================
--- llvm/trunk/test/Bindings/Ocaml/vmcore.ml (original)
+++ llvm/trunk/test/Bindings/Ocaml/vmcore.ml Mon Dec 17 21:49:35 2007
@@ -114,7 +114,7 @@
   end;
   
   begin group "qualified_pointer";
-    (* XXX: grep {QualPtrTy.*i8.*3.*\*} < %t.ll
+    (* RUN: grep {QualPtrTy.*i8.*3.*\*} < %t.ll
      *)
     let ty = qualified_pointer_type i8_type 3 in
     insist (define_type_name "QualPtrTy" ty m);





More information about the llvm-commits mailing list