[llvm-commits] [llvm] r45120 - in /llvm/trunk: include/llvm/Target/TargetInstrInfo.h lib/Target/Target.td

[Chris Lattner]

On Dec 17, 2007, at 1:02 PM, Bill Wendling wrote:
> As per feedback, revised comments to (hopefully) make the different  
> side effect
> flags clearer.
>
> ====================================================================== 
> ========
> --- llvm/trunk/include/llvm/Target/TargetInstrInfo.h (original)
> +++ llvm/trunk/include/llvm/Target/TargetInstrInfo.h Mon Dec 17  
> 15:02:07 2007
> @@ -91,17 +91,23 @@
>  // ARM instructions which can set condition code if 's' bit is set.
>  const unsigned M_HAS_OPTIONAL_DEF      = 1 << 17;
>
> +// M_NEVER_HAS_SIDE_EFFECTS - Set if this instruction has no side  
> effects that
> +// are not captured by any operands of the instruction or other  
> flags, and when
> +// *all* instances of the instruction of that opcode have no side  
> effects.
> +//
> +// Note: This and M_MAY_HAVE_SIDE_EFFECTS are mutually exclusive.  
> You can't set
> +// both! If neither flag is set, then the instruction *always* has  
> side effects.

Nice!

-Chris