[llvm-commits] [llvm] r45057 - /llvm/trunk/include/llvm/IntrinsicsX86.td

[Chris Lattner]

On Dec 14, 2007, at 10:16 PM, Chris Lattner wrote:
> On Dec 14, 2007, at 6:54 PM, Evan Cheng wrote:
>> Author: evancheng
>> Date: Fri Dec 14 20:54:12 2007
>> New Revision: 45057
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=45057&view=rev
>> Log:
>> __builtin_ia32_movqv4si is now expanded to a shuffle.
>
> Hi Evan,
>
> This breaks backwards compatibility with old .ll files.  Please keep  
> the intrinsic (in llvm, not needed in llvm-gcc) and add a "FIXME:  
> REMOVE IN LLVM 3.0" to it.

Actually, better yet: please update lib/VMCore/AutoUpgrade.cpp to turn  
the old intrinsic into the corresponding shuffle.  This gives us  
compatibility with old .ll and .bc files, but doesn't require us to  
keep the isel hooks around.

-Chris

>
> Thanks,
>
> -Chris
>
>>
>> Modified:
>>   llvm/trunk/include/llvm/IntrinsicsX86.td
>>
>> Modified: llvm/trunk/include/llvm/IntrinsicsX86.td
>> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/IntrinsicsX86.td?rev=45057&r1=45056&r2=45057&view=diff
>>
>> = 
>> = 
>> = 
>> = 
>> = 
>> = 
>> = 
>> = 
>> = 
>> =====================================================================
>> --- llvm/trunk/include/llvm/IntrinsicsX86.td (original)
>> +++ llvm/trunk/include/llvm/IntrinsicsX86.td Fri Dec 14 20:54:12 2007
>> @@ -460,8 +460,6 @@
>>  def int_x86_sse2_packuswb_128 :  
>> GCCBuiltin<"__builtin_ia32_packuswb128">,
>>              Intrinsic<[llvm_v8i16_ty, llvm_v8i16_ty,
>>                         llvm_v8i16_ty], [IntrNoMem]>;
>> -  def int_x86_sse2_movl_dq : GCCBuiltin<"__builtin_ia32_movqv4si">,
>> -              Intrinsic<[llvm_v4i32_ty, llvm_v4i32_ty],  
>> [IntrNoMem]>;
>>  def int_x86_sse2_movmsk_pd : GCCBuiltin<"__builtin_ia32_movmskpd">,
>>              Intrinsic<[llvm_i32_ty, llvm_v2f64_ty], [IntrNoMem]>;
>>  def int_x86_sse2_pmovmskb_128 :  
>> GCCBuiltin<"__builtin_ia32_pmovmskb128">,
>>
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>