[llvm-commits] [llvm] r44858 - in /llvm/trunk: include/llvm/Bitcode/LLVMBitCodes.h include/llvm/DerivedTypes.h include/llvm/GlobalVariable.h include/llvm/Instructions.h lib/AsmParser/LLLexer.cpp lib/AsmParser/llvmAsmParser.y lib/Bitcode/Reader/BitcodeReader.cpp lib/Bitcode/Writer/BitcodeWriter.cpp lib/VMCore/AsmWriter.cpp lib/VMCore/Constants.cpp lib/VMCore/Globals.cpp lib/VMCore/Instructions.cpp lib/VMCore/Type.cpp test/Assembler/2007-12-11-AddressSpaces.ll tools/llvm-bcanalyzer/llvm-bcanalyzer.cpp

[Chris Lattner]

On Dec 12, 2007, at 1:32 AM, Christopher Lamb wrote:

>
> On Dec 11, 2007, at 4:12 PM, Chris Lattner wrote:
>
>> Making the address space default to zero is convenient, but
>> dangerous.  This means that xforms that play with pointers need to be
>> very careful to propagate this info in some cases.  Do you think this
>> is the best way to go?  Do many clients of PointerType::get need to
>> be aware of addr spaces?
>
> I'm going to add a new method for getting a pointer type  
> 'PointerType::getUnqual()' that only takes an element type, the  
> standard 'PointerType::get()' will take both an element type and  
> address space with no default values. This should at least make it  
> explicit in the code which clients do not pass in an address space.  
> There are currently many clients, so this should help make the work  
> incremental.

Excellent idea,

-Chris