[llvm-commits] PR889 final version

[Gordon Henriksen]

On Dec 3, 2007, at 17:59, pawel kunio wrote:

> Whoah, pretty strange I get neither of those. I'm using compiler  
> from vs 2008 beta2 'orcas'. What compiler should I use to be more in  
> sync with the one used by You for verification? btw, I had a deeper  
> look into the Value class hierarchy and it seems that to remove all  
> vtables there will be a need to flatten Instruction hierarchy with  
> regard to the clone virtual method as well as Constant   
> destroyConstant,isNullValue,replaceUsesOfWithOnConstant methods) and  
> GlobalValue (isDeclaration method). Those as well as print and dump  
> methods will probably be blocking the Value destructor from being de- 
> virtualized.
>
> Anyway, please find the patch attached with the Value destructor  
> virtualized temporarily and with added 'class' clause to friend  
> Value declarations.

Thanks Pawel! I've applied your patch as rev 44747 here:

http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20071203/056105.html

Thanks again,
Gordon


P.S. The line endings in your patch were a bit problematic. All of the  
file contents themselves had Unix line endings, but the the diff  
structures (@@ X,Y and Index: etc.) were all in DOS format. It'd help  
save a bit of confusion if you can sort that for future submissions.