[llvm-commits] Re: updated patch for PR889

pawel kunio pawel.kunio at gmail.com
Thu Nov 29 01:57:16 PST 2007


As to the tabs and 80 char limit, already applied. Regarding the
patch, I'd say I'd rather stick
to the assert(0 && "Unknown 'subtype' instruction in Value destructor");
The reason is two-fold, 1. Some of the Value inherited class could
have escaped my searches
and 2. We will be able to enforce more strictly the destroyThis method
pattern in newly added
Value inherited classes.
What do You think?

Regard,
pawel



More information about the llvm-commits mailing list