[llvm-commits] [llvm] r44384 - in /llvm/trunk: include/llvm/Analysis/LoopInfo.h include/llvm/CodeGen/MachineLoopInfo.h lib/CodeGen/MachineLoopInfo.cpp

[Owen Anderson]

All of these are copy-and-pasted from LoopInfo.h.  If they're wrong,  
it's wrong too.  I'll investigate.

--Owen

On Nov 27, 2007, at 7:51 PM, Bill Wendling wrote:

> Hi Owen,
>
> Thanks! :-) A few comments:
>
>> +  // isLoopHeader - True if the block is a loop header node
>
> You probably want a /// comment here.
>
>> +  virtual void print(std::ostream &O, const Module* M = 0) const {
>> +    if (O) LI->print(O, M);
>> +  }
>
> I think that "if (O)" will always be true here, right?
>
>> +// Allow clients to walk the list of nested loops...
>> +template <> struct GraphTraits<const MachineLoop*> {
>> +  typedef const MachineLoop NodeType;
>> +  typedef std::vector<MachineLoop*>::const_iterator  
>> ChildIteratorType;
>
> Should this be:
>
>  typedef std::vector<const MachineLoop*>::const_iterator  
> ChildIteratorType;
>
> ?
>
> -bw
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits

-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 2555 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20071127/75dc0d7c/attachment.bin>