[llvm-commits] [llvm-gcc-4.2] r43909 - in /llvm-gcc-4.2/trunk/gcc: config/arm/arm.h llvm-convert.cpp

[Lauro Ramos Venancio]

>
> It seems like there is two options: when lowering from GCC asm to
> llvm asm, we can either change %@ (for example) into
> ASM_COMMENT_START.  Alternatively, we can lower it to "${:comment}",
> which llvm asm already expands out to the right thing.

Nowadays, LLVM doesn't expand this in inline asm. I tested this.

>  Does this
> make sense?  The important point here is that not all arm targets use
> @ for their comment character, and we don't want to break that.
>

I will use ASM_COMMENT_START. Nowadays, LLVM doesn't support any ARM
target that doesn't use '@' as comment character. So, I think it
doesn't worth to implement  "${:comment}" now.


Lauro